Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a lint + TypeScript type-check toolchain (scripts, ESLint/Prettier config, Husky/lint-staged hooks) and adds a dedicated GitHub Actions workflow to run linting and type checks on pushes/PRs.
Changes:
- Add
lint,type-check, andvalidatescripts plus Husky + lint-staged wiring for pre-commit checks. - Migrate ESLint configuration to an ESM flat-config style and expand Prettier configuration.
- Add a new CI workflow to run linting and
tsctype checks.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
src/app/features/todos/services/todos-storage.service.spec.ts |
Formatting tweak to match new Prettier settings (removes trailing commas in function args). |
package.json |
Adds scripts for lint/type-check/validate and tooling deps; sets ESM via "type": "module". |
eslint.config.js |
Replaces CJS config with ESM flat config; updates TS/Angular/template lint configuration. |
.prettierrc |
Expands/locks formatting rules and HTML override settings. |
.lintstagedrc.json |
Adds staged-file lint+format commands for TS files. |
.husky/pre-commit |
Adds pre-commit hook to run lint-staged. |
.github/workflows/lint-and-typecheck.yml |
New workflow to run lint and type-check in CI. |
.eslintrc.json |
Adds legacy ESLint config alongside the new flat config. |
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Adds repository-wide type checking + linting automation (scripts, ESLint/Prettier configuration, git hooks, and a CI workflow), plus minor spec formatting tweaks to align with the new formatting rules.
Changes:
- Add npm scripts for linting, type-checking, and validation; introduce Husky + lint-staged for pre-commit enforcement.
- Replace/update ESLint configuration (flat config) and add legacy
.eslintrc.json; expand Prettier configuration. - Add a GitHub Actions workflow to run lint + TypeScript type checks on PRs/pushes.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/features/todos/services/todos-storage.service.spec.ts | Formatting-only tweaks to match updated Prettier behavior (trailing commas in call sites). |
| package.json | Adds ESM mode + scripts and new tooling deps (ESLint, Angular ESLint, Husky, lint-staged). |
| eslint.config.js | Introduces ESLint flat config for TS + Angular templates. |
| .prettierrc | Expands/locks formatting rules and HTML override settings. |
| .lintstagedrc.json | Adds staged-file enforcement (eslint/prettier on *.ts). |
| .husky/pre-commit | Adds pre-commit hook to run lint-staged. |
| .github/workflows/lint-and-typecheck.yml | Adds CI job to run npm run lint and npm run type-check. |
| .eslintrc.json | Adds legacy ESLint config alongside the flat config. |
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
This PR introduces automated linting and TypeScript type-check validation across local development (husky/lint-staged) and CI, alongside migrating ESLint configuration to the flat-config ESM format.
Changes:
- Add
type-check/validatescripts and CI workflow to run ESLint + TS type checks. - Introduce husky + lint-staged pre-commit lint/format automation.
- Migrate ESLint config to ESM + flat config and expand Prettier configuration.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/features/todos/services/todos-storage.service.spec.ts | Adjusts test formatting (trailing commas) to satisfy formatting/lint rules. |
| package.json | Adds ESM mode, new lint/type-check scripts, husky/lint-staged dependencies, and updates ESLint-related deps. |
| eslint.config.js | Replaces CommonJS ESLint config with ESM flat-config; adds TS/Angular/template configurations. |
| .prettierrc | Expands Prettier options and HTML override settings. |
| .lintstagedrc.json | Adds lint-staged configuration for staged TS files. |
| .husky/pre-commit | Adds pre-commit hook to run lint-staged. |
| .github/workflows/lint-and-typecheck.yml | Adds CI workflow to run lint and type-check on pushes/PRs. |
| .github/actions/setup-ci/action.yml | Aligns Node version format and adds npm version alignment logic. |
You can also share your feedback on Copilot code review. Take the survey.
… version alignment step in CI setup
There was a problem hiding this comment.
Pull request overview
This PR introduces a stricter developer/CI validation pipeline by adding ESLint + Prettier + Husky/lint-staged setup and a dedicated GitHub Actions workflow to run linting and TypeScript type-checking.
Changes:
- Add scripts and dependencies for linting, formatting, Husky/lint-staged, and explicit TypeScript type-check commands.
- Migrate ESLint to a flat, ESM-based configuration and add Prettier/lint-staged configs.
- Add a CI workflow to run lint + type-check, and enhance the shared setup action to align npm with
packageManager.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/app/features/todos/services/todos-storage.service.spec.ts | Minor formatting tweak to JSON.stringify argument lists. |
| package.json | Adds validation scripts, ESM package type, and lint/type-check/Husky toolchain deps. |
| eslint.config.js | Replaces CommonJS config with ESM flat config for TS + Angular linting. |
| .prettierrc | Expands Prettier settings and HTML override options. |
| .lintstagedrc.json | Adds lint-staged rules for staged TS files. |
| .husky/pre-commit | Adds a pre-commit hook to run lint-staged. |
| .github/workflows/lint-and-typecheck.yml | New workflow running lint and type-check on push/PR. |
| .github/actions/setup-ci/action.yml | Uses 22.x default Node version and aligns npm to packageManager. |
You can also share your feedback on Copilot code review. Take the survey.
No description provided.